The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 280 | 25 | 0 | 0 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Exception is caught when Exception is not thrown in com.pyx4j.log.Log4jJMX.registerAppenderMBean(String, Appender) | STYLE | REC_CATCH_EXCEPTION | 151 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Result of integer multiplication cast to long in com.pyx4j.log.RollingFileAppender.rollOver() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 143 |
| Inconsistent synchronization of com.pyx4j.log.RollingFileAppender.fileCreated; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 180 |
| com.pyx4j.log.RollingFileAppender.debug should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 63 |
| com.pyx4j.log.RollingFileAppender.nameVariables isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 59 |
| Method call in com.pyx4j.log.RollingFileAppender.executeActivateOptions() passes null for unconditionally dereferenced parameter of String.replaceAll(String, String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 97 |
| Should com.pyx4j.log.RollingFileAppender.sortFileListByDate(File[]) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 227 |
| Write to static field com.pyx4j.log.RollingFileAppender.debug from instance method com.pyx4j.log.RollingFileAppender.setDebug(boolean) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 409 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.pyx4j.log.RollingFileAppender$FileListByDateComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to is in com.pyx4j.utils.AppConfiguration.loadProperties(Properties, URL) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 259 |
| com.pyx4j.utils.AppConfiguration.development should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available |
| Method com.pyx4j.utils.AppConfiguration.logSystemProperty() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 322 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to name in com.pyx4j.utils.CmdArgs.isArgsName(String) | STYLE | DLS_DEAD_LOCAL_STORE | 41 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Potentially dangerous use of non-short-circuit logic in com.pyx4j.utils.Execute.executeCommand(String, PrintStream, PrintStream) | CORRECTNESS | NS_DANGEROUS_NON_SHORT_CIRCUIT | 132 |
| com.pyx4j.utils.Execute.executeCommand(String, PrintStream, PrintStream) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 124 |
| com.pyx4j.utils.Execute.executeCommand(String, PrintStream, PrintStream) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 128 |
| Exception is caught when Exception is not thrown in com.pyx4j.utils.Execute.executeCommand(String, PrintStream, PrintStream) | STYLE | REC_CATCH_EXCEPTION | 148 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unread field: com.pyx4j.utils.Execute$StreamReaderThread.redirectLog | PERFORMANCE | URF_UNREAD_FIELD | 37 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 105 |
| com.pyx4j.utils.ExtProperties.retrieveEnvVars() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 114 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 31 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Class com.pyx4j.utils.service.SocketAcceptorService implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Invocation of toString on an array in com.pyx4j.utils.service.StreamRelayer.execute() | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 62 |
| Possible null pointer dereference of StreamRelayer.listeners in com.pyx4j.utils.service.StreamRelayer.notifyListeners() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 114 |
| Class com.pyx4j.utils.service.StreamRelayer implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | Not available |